Switch to npm #3831
Merged
Switch to npm #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Start using npm instead of yarn. We are still using yarn classic which is deprecated. Therefore switch to npm.
Use current Debian stable (bookworm), nodejs 18 (LTS) and npm to build and install GSA for the container image. This updates to current maintained software and removes the extra dependency on yarn.
Drop yarn in favor of npm and use currently supported nodjs version 18 and 20.
Replace yarn with npm for creating the release files.
Using npm requires passing `--` before the extra arguments.
timopollmeier
force-pushed
the
switch-to-npm
branch
from
787cdb3 to
8af9e91
Compare
timopollmeier
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Drop yarn in favor of npm
yarn-->npm installyarn build-->npm run buildyarn test-->npm run testWhy
Using yarn with newer versions of nodejs caused build errors. Therefore to allow using current maintained nodejs version 18 and 20 drop yarn in favor of npm.
When we did choose yarn at the beginning of the GSA JavaScript version, yarn was much faster and more reliable. But in the meanwhile npm got on par to yarn's features and speed. Additionally the yarn project changed it's direction and re-implemented yarn which resulted in the 2.x and later versions and abandoned 1.x which we use(d).
Therefore drop yarn and switch to npm which allows to use maintained software again.